search

samshull / node-proxy

Deprecated: Harmony Proxies in node (no longer needed)
MIT License
162 stars 29 forks source link

Use `bindings` to properly load the binding #32

Closed mmalecki closed 10 years ago

mmalecki commented 10 years ago

Sometimes the binding file isn't outputted in build/Release/nodeproxy.node, but for example in build/Debug/nodeproxy.node. bindings module covers all the possible cases.

max-mapper commented 10 years ago

+1 just ran into this

samshull commented 10 years ago

Sorry, just been swamped and no time to test this patch. I will get it merged and pushed by next week.

samshull commented 10 years ago

Actually, based on http://felixge.de/2013/03/11/the-pull-request-hack.html I have decided to give @mmalecki commit rights for this repo. Feel free to merge this commit and if you want I will add you as an owner of the npm repo.

mmalecki commented 10 years ago

Thanks Sam! Merging this pull requests, tests pass on v0.8 and v0.10.