Closed duralog closed 10 years ago
(with the windows bit removed from node.h)
So, will this still work on windows? I don't actually care, but I am still curious.
I certainly like the nan library.
in node-0.11.11 there was a bit added to the node.h which fixed a few things on windows, but it made node modules basically uncompilable for POSIX systems. I removed the part referenced in tis PR to get it compiling: https://github.com/joyent/node/pull/6992 (it's a PR to revert that broken code)
I really like the nan library too :) I'm gonna convert a few more modules I use over to it. now that I have the hang of it, it's easy :) I like how clean node-proxy is now. it's actually understandable what's going on and it gave me some good ideas to use getters/setters for other things now too
Do you want to add your name to the contributors list? Sort of acquiescing that you are releasing your changes as MIT, I guess. And this is a pretty big change.
yes, MIT, of course.
hehe yea took me about 4-5 hours to do it all... I thought it was going to be "easy" :D
ok I'll add my name in a second. EDIT: added
this was a pretty hefty conversion, but all the tests are passing. it builds and runs on:
I also did some maintenance in the second commit. feel free to ignore it.
few things to note:
cheers!