Closed duralog closed 10 years ago
I tried to build this with 0.11.2 and it failed, but 0.11.13 works fine. Please update package.json with the minimum appropriate node version for these changes.
It's 0.8, 0.10 or latest 0.11. 0.11 is the current development release which goes through major changes on each revision until it stabilizes as 0.12.0. The 0.11-series can be divided into three major parts: 0.11.0--0.11.3, 0.11.4--0.11.12, 0.11.13--0.12.0. There is no reason to run a development version that is older than the latest, as the development branch is transient until development is finished and it becomes a stable branch. However would not requiring node >=0.11.13 in package.json erroneously exclude all of 0.8 and 0.10?
@kkoopa It already doesn't work with < 0.11 anyway.
Ah, that explains it of course.
@duralog please update the node version required in package.json as well.
hey, so I have good news: if I reverted the change @kkoopa suggested for the ternary expression and some other tiny modifications, I have the code compiling, running and passing all tests on 0.11.13, 0.10.28, and 0.8.26 ... I'm gonna test 0.6 now and then commit with a node version restriction of 0.6+ or 0.8+.. cool?
nevermind the 0.6 support... I was being optimistic. that shit is old.
gonna commit with 0.8 support
updated for nan-1.1.0 passing all tests & added a travis file in case you do automatic testing :+1:
I just added 0.8 to travis as well. you can add it to repo like this: http://docs.travis-ci.com/user/getting-started/
hey bro... this updates to the latest nan version for node v0.11.13 support (the api that will basically be 0.12).
some things:
cheers!