search

samshull / node-proxy

Deprecated: Harmony Proxies in node (no longer needed)
MIT License
162 stars 29 forks source link

Fails to build under node 0.12.x #39

Closed natevw closed 9 years ago

natevw commented 9 years ago

I know I can now start scripts with node --harmony-proxies to get V8 built-in support for Proxy but for scripts that still depend on this library (and situations where it's a pain to start node with custom flags), I'm wondering if this is a simple fix to get it working again?

Complete log here: https://gist.github.com/natevw/c45b5abdc79f34c84729

samshull commented 9 years ago

fixed by https://github.com/samshull/node-proxy/commit/7aa4c269079d95b59ff2e39b76e46abc434635e4

natevw commented 9 years ago

Awesome, thanks for the quick turnaround! (I'm using this in https://github.com/natevw/fermata — and the version where it's an optional dependency is still under development, so this will be appreciated by users of the stable version where it's still required.)