Compilation fails with Node 4.0.0

samshull / node-proxy

Deprecated: Harmony Proxies in node (no longer needed)

MIT License

162 stars 29 forks source link

Compilation fails with Node 4.0.0 #42

Closed JonAbrams closed 9 years ago

JonAbrams commented 9 years ago

I'm on OSX 10.10.5 (and Xcode 7) and receive the following fatal error when installing node-proxy:

In file included from ../src/node-proxy.cc:33:
In file included from ../src/./node-proxy.h:40:
../node_modules/nan/nan.h:324:27: error: redefinition of 'NanEnsureHandleOrPersistent'
  NAN_INLINE v8::Local<T> NanEnsureHandleOrPersistent(const v8::Local<T> &val) {
…

samshull commented 9 years ago

This is not the same issue? https://github.com/samshull/node-proxy/pull/41

JonAbrams commented 9 years ago

Oops, sorry.