samskivert / jmustache

A Java implementation of the Mustache templating language.
Other
828 stars 129 forks source link

Inheritance support #120 #157

Closed agentgt closed 7 months ago

agentgt commented 7 months ago

@samskivert

This PR adds inheritance support. It currently passes all the spec tests as well as some additional ones I added via custom yaml files.

I have tried not break API by making the Visitor interface use default methods. I'm not sure if the default I chose is correct for blocks and parents (currently skipped).

This should fix #120

Before we add additional optional specification enhancements I think we should do a release. The other optional things like dynamic names are not nearly requested as much and frankly I consider them dangerous but we can add them later.

I tried to follow your formatting but I may have slipped in a few places. I plan on setting up a formatter that follows the style but just haven't gotten around to it yet.

samskivert commented 7 months ago

Thanks!