Closed pierrejochem closed 6 years ago
missing test and need to have updated/added at spec
directory, I'm using kahlan
Working on the changes and will add the test(s)
Could you give me an advise for kahlan please? I've search for something for the email functionality so I can orientate on it or use it as template for the mqtt stuff, but can not find it.
you can create new integration test for it with new fixture config and new integration via error preview class, for example, on enable email:
config fixture with mail-message
and mail-transport
definition that services defined under service_manager
: https://github.com/samsonasik/ErrorHeroModule/blob/8990c518bc4b2dcf356a45da3ed327ed670622b3/spec/Fixture/config/autoload-with-enable-sendmail/error-hero-module.local.php
integration class: https://github.com/samsonasik/ErrorHeroModule/blob/8990c518bc4b2dcf356a45da3ed327ed670622b3/spec/Integration/IntegrationViaErrorPreviewControllerWithEnableSendMailSpec.php
To do this, you need to add "mcfish/libmqtt": ^1.0.1
to require-dev
for using Client class (testing purpose) and suggest
to suggest when user want to use mqtt notification.
after more thinking about it, I think you can just create custom Writer, register service under log_writers
, then add the writer under log
-> ErrorHeroModuleLogger
-> writers`, hence I close it ;)
I will check this out. Thank you. I had my code finished, but problems with kahlan
Mqtt sending feature