samsonasik / SanSessionToolbar

:zap: Session Toolbar that can be applied into Zend/Laminas DeveloperTools
MIT License
38 stars 11 forks source link

[docs] ZF3 Missing flash messenger plugin #55

Closed xorock closed 8 years ago

xorock commented 8 years ago

For ZF3 there is no require section in composer.json for "zendframework/zend-mvc-plugin-flashmessenger": "^1.0"

Perhaps it is worth mentioning in the documentation that plugin is required for proper operation?

samsonasik commented 8 years ago

should be on "suggest" section in composer.json, wanna create a PR about it?

Thank you.

Warm regards,

Abdul Malik Ikhsan

Pada 28 Agt 2016, pukul 20.08, xorock notifications@github.com menulis:

For ZF3 there is no require section in composer.json for "zendframework/zend-mvc-plugin-flashmessenger": "^1.0"

Perhaps it is worth mentioning in the documentation that plugin is required for proper operation?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

samsonasik commented 8 years ago

the code itself in Module.php needs check if service has plugin named 'flashMessenger'

Warm regards,

Abdul Malik Ikhsan

Pada 28 Agt 2016, pukul 20.08, xorock notifications@github.com menulis:

For ZF3 there is no require section in composer.json for "zendframework/zend-mvc-plugin-flashmessenger": "^1.0"

Perhaps it is worth mentioning in the documentation that plugin is required for proper operation?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

samsonasik commented 8 years ago

@xorock fixed at https://github.com/samsonasik/SanSessionToolbar/commit/d4911c650733b5a328ed6e47825277af46db9953 , Thank you for the report ;)