Rescue after_error callback errors

samsondav / rihanna

Rihanna is a high performance postgres-backed job queue for Elixir

MIT License

439 stars 47 forks source link

Rescue after_error callback errors #49

Closed sadir closed 5 years ago

sadir commented 5 years ago

If a job fails currently, it attempts an after_error/2 callback.

If that callback exists it is run. If it doesn't the dispatcher moves on.

This commit handles the case where the callback is there, but it raises an error. Previously if this happened, the dispatcher would die and the job would be put back on the queue and picked up again when a new dispatcher was created.

sadir commented 5 years ago

I'll bump version etc if you're happy with the concept and implementation @samphilipd

samsondav commented 5 years ago

Please go ahead and bump version etc @sadir

sadir commented 5 years ago

Yeah that's exactly what would happen

samsondav commented 5 years ago

Yup, bump to 1.2.2 and don't forget the changelog.

samsondav commented 5 years ago

:shipit: