samsondav / rihanna

Rihanna is a high performance postgres-backed job queue for Elixir

MIT License

439 stars 49 forks source link

Job.delete_by/1 #61

Closed VitorTrin closed 5 years ago

VitorTrin commented 5 years ago

60

samsondav commented 5 years ago

@VitorTrin Is this ready for review? Where are we at on this?

VitorTrin commented 5 years ago

It's been ready for review for a while, but it's up to you guys if you want this merged, this solution doesn't worry about memory costs of loading all the jobs in memory, but that is ok for my use case and I'm already using it in production.I don't plan on addressing that on my own.

How that is addressed also depends on if the way jobs are stored will be changed or not.

samsondav commented 5 years ago

@VitorTrin yup it looks fine, can you add an entry to the changelog? Then I'll merge.

samsondav commented 5 years ago

@vitortrin Hey bud, I'd like to get this in for the 2.0 release - sorry to be a pain, can you rebase?

VitorTrin commented 5 years ago

Rebase done!