Refactor Keyword Checker class

samsontmr / oss-bot-js

Bot for managing first level PR reviews on OSS GitHub repos

2 stars 2 forks source link

Closed Skaty closed 7 years ago

Skaty commented 7 years ago

Keyword Checker does not follow SRP, as it does both checking of PR messages and generation of message response for bot.

samsontmr commented 7 years ago

You mean SRP?

samsontmr commented 7 years ago

How do you suggest refactoring it? Move the getFeedback method into the main logic and split Keyword Checker up?