search

samsta / BatteryController

GNU General Public License v3.0
0 stars 0 forks source link

Implement NaN values in SMA Messages #1

Open samsta opened 3 years ago

samsta commented 3 years ago

Messages need to be able to convey that some values are invalid, e.g. when we haven't received that information from the Battery (yet) or when the simply don't apply (e.g. missing sensor).

That's what the column AC in Value List -CAN - Modified.xlsx on dropbox is for.

NiallDarwin commented 2 years ago

I don't think we care about SMA anymore.. Close this?

samsta commented 2 years ago

Yep - do you want to delete everything SMA?

NiallDarwin commented 2 years ago

Can it be deleted in a reversible way - ie if we ever end up going back to the stanists we can resurrect it?

samsta commented 2 years ago

That’s the whole point of using a version control system like git. It remembers the history back to the dawn of time and any previous version can be resurrected

Sent from my iPhone

On 14/01/2022, at 9:41 AM, Niall Darwin @.***> wrote:

 Can it be deleted in a reversible way - ie if we ever end up going back to the stanists we can resurrect it?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

NiallDarwin commented 2 years ago

Sometimes the thing that's the whole point of a technology ends up not working. EG cars and roads for rapid transport and freedom leads to traffic jams and people enslaved to paying for their vehicles. However I take it you're saying git actually works and it won't be an absolute git to resurrect the SMA stuff if needed. Getting it to integrate with however the program has evolved may be a different story but that's life. In short, yes, let's kill all the SMA stuff.