samsta / BatteryController

GNU General Public License v3.0
0 stars 0 forks source link

Unlatch shunt relay if current is less than |1.5| #19

Open NiallDarwin opened 1 year ago

NiallDarwin commented 1 year ago

Unlatch shunt relay if current is less than |1.5| Currently when shunt is fired due to pack problem power remains on to the control relay. Change so it stops powering the relay once pack current has dropped to less than |1.5|A

JimsterCoder commented 1 year ago

Current limit set to 1.01A Shut trip relay de-energized when battery current below this value.

This code needs to be tested. TESTS need to be written for TeensyShutCtrl (and perhaps for TeensyRelay)

JimsterCoder commented 11 months ago

Code needs to be re-thought. Has been removed.

NiallDarwin commented 11 months ago

Can you be a little less cryptic so that when we return to it we know what it is about the code that needs to be rethought? Why wasn't it right?

JimsterCoder commented 11 months ago

Code needs to be changed so the shunt status can be set for multiple reasons but the physical tripping of the shunt is only done in one place... and the reset done in one place.