search

samstarling / finagle-prometheus

Provides a bridge between Finagle and Prometheus metrics
https://samstarling.co.uk/projects/finagle-prometheus/
MIT License
30 stars 18 forks source link

Fix gauges #22

Closed spockz closed 6 years ago

spockz commented 6 years ago

@samstarling Please take a look at this.

samstarling commented 6 years ago

Looks good, thank you. I agree on the poll interval comment (in your commit message), but I don't have any immediate suggestions there. I'll have a think about it, and I'll try and get another release out soon.

spockz commented 6 years ago

We just found some bugs internally with this version. Please hold off releasing this. I’ll share a new merge request shortly.

On 18 Apr 2018, at 08:02, Sam Starling notifications@github.com wrote:

Looks good, thank you. I agree on the poll interval comment (in your commit message), but I don't have any immediate suggestions there. I'll have a think about it, and I'll try and get another release out soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.