search

samstarling / finagle-prometheus

Provides a bridge between Finagle and Prometheus metrics
https://samstarling.co.uk/projects/finagle-prometheus/
MIT License
30 stars 18 forks source link

Add correct synchronization because of trie map and fix gaugeProviders #23

Closed spockz closed 6 years ago

spockz commented 6 years ago

Gauges should be added before gaugeProvider because we iterate over the providers to find the matching gauge. This way the gauge is always there at the cost of maybe missing a update round.

Fixes #21.

samstarling commented 6 years ago

Good spot, thanks for this – and for adding the test as well. Sorry that this took me so long to merge and respond to: I'll release a new version now.

samstarling commented 6 years ago

I've just released 0.0.7, and it's being synced with Maven Central now.

spockz commented 6 years ago

Great, thank you!