samstarling / finagle-prometheus

Provides a bridge between Finagle and Prometheus metrics
https://samstarling.co.uk/projects/finagle-prometheus/
MIT License
30 stars 18 forks source link

Fix race condition issue reported in #24 #25

Closed samstarling closed 6 years ago

samstarling commented 6 years ago

The chaining of two getOrElseUpdate calls could result in two separate threads attempting to register the same counter. Widening the scope of the synchronised section should remedy this.

Thanks to @seanbrant for reporting this.

seanbrant commented 6 years ago

💯