search

samstarling / finagle-prometheus

Provides a bridge between Finagle and Prometheus metrics
https://samstarling.co.uk/projects/finagle-prometheus/
MIT License
30 stars 18 forks source link

Fall back to a JavaTimer if a DefaultTimer instance can't be fetched #29

Closed samstarling closed 6 years ago

samstarling commented 6 years ago

@Fluxx: This supersedes #28. Take a look and let me know what you think, and I'll try and get this merged/released ASAP so that you can validate whether it helps or not. Hopefully it will.

Fluxx commented 6 years ago

Generally looks good to me though, sans the daemon question.

samstarling commented 6 years ago

@Fluxx Good call. Once this has built, I'll merge and release. Sorry it's taken a while!

Fluxx commented 6 years ago

Just checking in on this.

samstarling commented 6 years ago

@Fluxx Sorry for the delay: I've just released 0.0.10 to Bintray, and it's syncing to Maven Central at the moment. Can you let me know if it fixes things for you? I still think there's a race condition in there somewhere, but I'll pick that up as a separate issue.

Fluxx commented 6 years ago

I'll give it a shot and see. I had actually internally been using the old version but with an alternate constructor usage to use the JavaTimer. However, I ran into another issue involving any stats which don't seem to have any amount of nesting. I believe the metric is coming from finagle itself.