search

samstarling / finagle-prometheus

Provides a bridge between Finagle and Prometheus metrics
https://samstarling.co.uk/projects/finagle-prometheus/
MIT License
30 stars 18 forks source link

Upgrade to finagle 19.4.0 #39

Closed hderms closed 5 years ago

hderms commented 5 years ago

the absence of:

https://github.com/twitter/util/commit/52d49ad98c3ec3b08218a60d6ede322c0f7edc5e#diff-17875bdf59a97a432ccfe4dd7e877be1

is causing me to get a weird reflection error when starting my server using finagle-prometheus:

[error] java.lang.IllegalArgumentException: wrong number of arguments
[error]         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[error]         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[error]         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[error]         at java.lang.reflect.Method.invoke(Method.java:498)
[error]         at com.twitter.jvm.Hotspot$.gcFromNotificationInfo(Hotspot.scala:260)
[error]         at com.twitter.jvm.Hotspot$$anon$1.handleNotification(Hotspot.scala:95)
[error]         at sun.management.NotificationEmitterSupport.sendNotification(NotificationEmitterSupport.java:156)
[error]         at sun.management.GarbageCollectorImpl.createGCNotification(GarbageCollectorImpl.java:143)

which seems to be confirmed in: https://github.com/twitter/util/issues/244

as far as I can see this requires an upgrade to 19.4.0 to resolve, though in these threads they claim the bug is harmless