search

samstarling / finagle-prometheus

Provides a bridge between Finagle and Prometheus metrics
https://samstarling.co.uk/projects/finagle-prometheus/
MIT License
30 stars 18 forks source link

Minor bugfix when extracting metricName and labels #46

Closed JustinVenus closed 5 years ago

JustinVenus commented 5 years ago

Fixes https://github.com/samstarling/finagle-prometheus/issues/43

When including com.samstarling.prometheusfinagle.PrometheusStatsReceiver in resources/META-INF/services/com.twitter.finagle.stats.StatsReceiver a fatal exception is encountered. The cause isSeq("finagle", "build/revision"). My proposed fix checks the input sequence and ensures the input is valid.

samstarling commented 5 years ago

Hi @JustinVenus – thanks for the contribution, and for spotting this bug. Would you also be able to add a test for this behaviour please?

JustinVenus commented 5 years ago

@samstarling would you like me to change/update the test? Would you like me to reorder or squash commits?

samstarling commented 5 years ago

@JustinVenus No, this looks good! Thanks again for this, and I'm sorry for the delay in replying to you. I'll merge this now, and should be able to get a release out over the weekend.

samstarling commented 5 years ago

This has just been released in 0.0.14 – sorry for the delay.