search

samstarling / finagle-prometheus

Provides a bridge between Finagle and Prometheus metrics
https://samstarling.co.uk/projects/finagle-prometheus/
MIT License
30 stars 18 forks source link

Write some "getting started" documentation #5

Closed samstarling closed 6 years ago

samstarling commented 7 years ago

To be friendly to new users and promote usage, it'd be good to have an example of how to get up and running with the library.

olli-miettinen-arm commented 7 years ago

This would be nice to have.

samstarling commented 6 years ago

Hey @olli-miettinen-arm – I just updated the README, and there's now also an examples directory. Would you mind taking a look and letting me know if it's useful?

samstarling commented 6 years ago

I just gave the README some love, and now it has a proper description of everything the library does. @spockz, you might also be interested in this.

spockz commented 6 years ago

Nice. :)

Maybe we should also address how to set the per host statsreceiver and which extension possibilities the PrometheusStatsReceiver has.

Do you want to do that in a separate issue?

On 8 Jan 2018, at 13:59, Sam Starling notifications@github.com wrote:

I just gave the README some love, and now it has a proper description of everything the library does. @spockz https://github.com/spockz, you might also be interested in this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/samstarling/finagle-prometheus/issues/5#issuecomment-355959922, or mute the thread https://github.com/notifications/unsubscribe-auth/AADVMwz6MiHP_wgGVsRan1uIHxzDlxf_ks5tIhEogaJpZM4LbpcR.

samstarling commented 6 years ago

@spockz Good idea, I just raised a new issue for this!