search

samstyle / Xpeccy

Multiplatform emulator of retro computers
MIT License
73 stars 14 forks source link

Possible error ? #105

Closed ZanyXDev closed 3 years ago

ZanyXDev commented 3 years ago

https://github.com/samstyle/Xpeccy/blob/56e66c7335f47df3c215b4856e843434bf2bc8bf/src/emulwin.cpp#L86

Why use ~Qt::WindowFullScreen

ped7g commented 3 years ago

without checking Xpeccy source, this looks like "set window state to windowState() except full-screen", ie. this will either always reset to non-fullscreen, or not affect full-screen (depends on semantics of setWindowState how it deals with full screen bit set to zero.

samstyle commented 3 years ago

yep, this is 'reset fullscreen bit'