search

samsymons / RedditKit.rb

[Deprecated] A Ruby wrapper for the reddit API
https://redditkit.com/
MIT License
152 stars 26 forks source link

Add all options available for Search #14

Closed BukhariH closed 10 years ago

BukhariH commented 10 years ago

https://pay.reddit.com/dev/api#GET_search All the options above added.

Closes https://github.com/samsymons/RedditKit.rb/issues/12

P.S. Sorry for the awful documentation! :L

jtoy commented 10 years ago

I see the build failed, is this code working?

BukhariH commented 10 years ago

@jtoy The builds fail because I don't have API keys set :smile:

Just like if you see here: https://github.com/samsymons/RedditKit.rb/pull/13

The build failed on my pull request but worked when it was merged in :)

BukhariH commented 10 years ago

I also went ahead added a .env file and ran the tests to make sure: Rspec Tests

The two failures are due to my test account not being a moderator but otherwise everything passed.

jtoy commented 10 years ago

awesome, can we get this new version on ruby gems ?

samsymons commented 10 years ago

Absolutely, I'll have this merged in and released by tonight.