search

samsymons / RedditKit.rb

[Deprecated] A Ruby wrapper for the reddit API
https://redditkit.com/
MIT License
152 stars 26 forks source link

Fix Client.register doc and functionality #3

Closed euank closed 7 years ago

euank commented 10 years ago

Register api documentation was inaccurate and required captcha items were in the options hash. Email was also missing.

The version bump I'm not sure you actually want. Feel free to disregard it or ask me to redo the pull request without it.

samsymons commented 10 years ago

This is good, thanks. I'm gonna hold off on merging it for now as I plan to have OAuth implemented very soon, so I'll keep that for the version 2 bump.

BukhariH commented 10 years ago

@euank could you send another pull request with just commit b7ec6d8 as it's useful however is still backwards compatible.

euank commented 10 years ago

@BukhariH: added as #15

BukhariH commented 10 years ago

@euank Thanks Euan!

jtoy commented 10 years ago

is oauth coming in?

samsymons commented 10 years ago

@jtoy Yep, sorry for taking so long on that, I keep getting distracted by everything else. I'll be taking a look at that on Thursday.

jtoy commented 10 years ago

Just checking, is there a timeline for oauth?

samsymons commented 10 years ago

Quite soon – I'm working on it as we speak. Sorry for taking so long with it, I've recently started a new job so life has been pretty hectic.

jtoy commented 10 years ago

hi :)

BukhariH commented 10 years ago

@jtoy There is no easy way to implement oauth without messing it up massively. And, you don't have to look far to see some example's of poor oauth implementation (which aren't due to bad developers).

An example being GitHub: http://homakov.blogspot.co.uk/2014/02/how-i-hacked-github-again.html

Implementing it the right way is about atleast 2-3 weeks work.

Secondly, we have to decide how do we want to implement it. Do we want to Faraday and Oauth using middleware or do we want a separate library like oauth2 working in conjunction with faraday?

Apart from that reddit's documentation for Oauth is terrible. There is literally only this page: https://github.com/reddit/reddit/wiki/OAuth2

euank commented 7 years ago

I don't actively use this library anymore and I'd need to rebase.

If this change is still needed, anyone else is welcome to pick up my changes and carry them, but I'll just close this since I have no plans to act further here.