Open blakejakopovic opened 9 years ago
I'm guessing this is related to the issue I was just seeing. Here's the backtrace (clipped to include redditkit-related lines):
TypeError: no implicit conversion of Symbol into Integer
/home/me/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/redditkit-1.0.2/lib/redditkit/client/utilities.rb:72:in `[]'
/home/me/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/redditkit-1.0.2/lib/redditkit/client/utilities.rb:72:in `object_kind_from_response'
/home/me/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/redditkit-1.0.2/lib/redditkit/client/utilities.rb:41:in `object_class_from_response'
/home/me/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/redditkit-1.0.2/lib/redditkit/client/utilities.rb:79:in `object_from_response'
/home/me/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/redditkit-1.0.2/lib/redditkit/client/users.rb:17:in `user'
/home/me/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/redditkit-1.0.2/lib/redditkit/client/account.rb:22:in `sign_in'
/home/me/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/redditkit-1.0.2/lib/redditkit/client.rb:61:in `initialize'
It looks like the problem was the response body while logging in was empty. I dug in a bit and found this seemed to be because the signin request was being served a 301 redirect response, redirecting to https://www.reddit.com/...
instead of http://...
. Here's the response from faraday:
#<Faraday::Env @method=:get @body="" @url=#<URI::HTTP http://www.reddit.com/user/<me>/about.json> @request=#<Faraday::RequestOptions (empty)> @request_headers={"User-Agent"=>"Faraday v0.9.1", "Cookie"=>"reddit_session=<session>", "X-Modhash"=>"<hash>"} @ssl=#<Faraday::SSLOptions (empty)> @response_headers={"retry-after"=>"0", "location"=>"https://www.reddit.com/user/<me>/about.json", "content-length"=>"0", "accept-ranges"=>"bytes", "date"=>"Tue, 20 Sep 2016 21:26:47 GMT", "via"=>"1.1 varnish", "connection"=>"close", "x-served-by"=>"cache-dfw1843-DFW", "x-cache"=>"HIT", "x-cache-hits"=>"0", "x-timer"=>"S1474406807.209149,VS0,VE0", "cache-control"=>"private, max-age=3600", "server"=>"snooserv"} @status=301>
(Note how url
and response_headers['location']
)
I fixed this by setting the api_endpoint on my client:
@client = RedditKit::Client.new
@client.api_endpoint = 'https://www.reddit.com'
@client.sign_in('me', 'hunter2')
Wondering if 'https://www.reddit.com' should be the default API endpoint?
When a reddit user enables forced SSL, it seems to break the API. I've tested it using the
save
andunsave
methods on a post. It returns a 307 redirect, and the method fails. I'm not sure what's involved to get this working. For now the fix is to disable forced SSL for the account.