Adding href feature to the navigation items

samthecodingman / app-bottom-nav

A Material Design bottom navigation component for Polymer

https://www.webcomponents.org/element/samthecodingman/app-bottom-nav

MIT License

3 stars 2 forks source link

Adding href feature to the navigation items #3

Open jobizzness opened 7 years ago

jobizzness commented 7 years ago

Hi, First of all thank you for building this component. I also think it will be helpful to have this behave like iron selector.

<app-bottom-nav-item icon="icons:trending-up" label="Trending" href="/"></app-bottom-nav-item>

samthecodingman commented 7 years ago

Hiya Jobizzness,

I can't find a reference to using href for "iron-selector". However, I will look into implementing the href attribute in the coming days. It will likely be a seperate element called app-bottom-nav-link-item as I suspect there will be a number of CSS related bugs that will be caused by introducing the anchor elements.

jobizzness commented 7 years ago

That will be quite helpful. looking forward to it. Thanks