search

samthor / rippleJS

vanilla Material Design ripples
https://samthor.github.io/rippleJS
MIT License
190 stars 22 forks source link

Account for anchor elements' dragging event instead of mouseup #10

Open nox7 opened 5 years ago

nox7 commented 5 years ago

When a user clicks on an anchor like so:

<a href="#">
    Hello
    <div class="rippleJS"></div>
</a>

Then drags away after a mousedown event, a mouseup event never fires. This is because a dragging starts, as most developers do not add draggable="false" to their anchors. Thus, the ripple stays until the users click in the document elsewhere.

This can be remedied by checking if the tagName of the ripple's parent is "A" and then also checking if a "mouseup" event is being listened after mousedown. Simply check for a "dragend" as well to fire the same function.

Identified in Chromium-based v71.0.3578.98

katriellucas commented 4 years ago

Hello, I'm interested on this issue as well, can you help me out on how to solve it? A lot of other ripple libs have this issue as well, I'm probably forking this.