samtiria / nextgen-gallery

Automatically exported from code.google.com/p/nextgen-gallery
0 stars 0 forks source link

Adblock breaks gallery popup view webkit. #398

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Install Adblock Plus Beta on Google Chrome (or similar on Safari)
2. Go to a NextGEN Gallery like http://nextgen-gallery.com/ under the search 
box open a picture and go through the pictures

What is the expected output? What do you see instead?
The pics will go down the page so you have to scroll down and the controls 
(next, prev) is on the edges of the site.

What version of the product are you using? On what operating system?
Google Chrome 13, Safari (latest?), Adblock 1.1.3

Please provide any additional information below.
It is a known issue but seems to be solveable for nextgen as other have.
http://adblockplus.org/en/known-issues-chrome

Original issue reported on code.google.com by anteu...@gmail.com on 30 Jul 2011 at 1:14

GoogleCodeExporter commented 8 years ago
And what is the solution if it's solveable ?

Original comment by alex.cologne on 30 Jul 2011 at 1:34

GoogleCodeExporter commented 8 years ago
"The issue has been resolved by imgZoom 0.2.1. What was going on is that the 
script was using an image's offsetWidth property in a handler to the image's 
'load' event. Somehow the presence of any beforeload event listener delays the 
setting of offsetWidth to just after the handler is called (as can be seen 
using a setTimeout of 0 milliseconds), but it is not set within the handler 
(i.e. equals 0). Since the spec does not require .offsetWidth to be set when 
the 'load' event is fired (the image's .width property has this purpose and 
works correctly), this behavior seems legit, although the fact that it happens 
exclusively with beforeload listeners indicates that it might be the 
consequence of another bug."

It was solved with imgZoom.

I'm using #shDisplay {top:1% !important;) as a temp fix but it doesn't look 
that good: http://ingasjodin.se/?p=tavlor
And the controls isn't fixed.

Original comment by anteu...@gmail.com on 30 Jul 2011 at 1:37

GoogleCodeExporter commented 8 years ago
So I'm testing some modifications of:

if ( ! t.Top ) {
    if ( window.pageYOffset != 0 ) t.Top = window.pageYOffset;
        else t.Top = (document.documentElement.scrollTop > 0) ? document.documentElement.scrollTop : document.body.scrollTop; 
}

Original comment by anteu...@gmail.com on 30 Jul 2011 at 1:41

GoogleCodeExporter commented 8 years ago
Maybe this should be a similar issue as reported in issue #381 

Original comment by alex.cologne on 30 Jul 2011 at 1:49

GoogleCodeExporter commented 8 years ago
Thanks I will try that! Brb

Original comment by anteu...@gmail.com on 30 Jul 2011 at 1:50

GoogleCodeExporter commented 8 years ago
http://ingasjodin.se/?p=tavlor

There it didn't do it. Buttons still screwed and that is still with the 1% fix.

Original comment by anteu...@gmail.com on 30 Jul 2011 at 2:13

GoogleCodeExporter commented 8 years ago
Until somebody give me a hint where to look, I will close this as I see no 
failure at my side

Original comment by alex.cologne on 14 Aug 2011 at 6:38

GoogleCodeExporter commented 8 years ago
This is the error when I have latest Google Chrome Beta and Adblock Plus Beta.

Original comment by anteu...@gmail.com on 14 Aug 2011 at 11:10

Attachments:

GoogleCodeExporter commented 8 years ago
I have tracked this error, it's a WebKit problem. This has now been committed 
and I can confirm that Google Chrome beta (16) no longer displays this issue, 
and I imagine Safari will follow suit.

Cheers
Russ

Original comment by russtar...@gmail.com on 20 Nov 2011 at 5:08

GoogleCodeExporter commented 8 years ago
Ah yes looking good now, thanks!

Original comment by anteu...@gmail.com on 20 Nov 2011 at 5:51