samtiria / nextgen-gallery

Automatically exported from code.google.com/p/nextgen-gallery
0 stars 0 forks source link

WP minimum version #463

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I have been digging a bit more into the code and found a few things.

1. I have attached a patch which renames $WP_minium to $WP_minimum. I know it 
is just a spelling mistake, but thought I would correct it anyway. It is the 
nggallery.php.patch

2. Currently the minimum version is set to 3.1, which means that the if clause 
in the admin/admin.php which checks for a version greater than 3.0.9999 will 
always be true. So I have attached a patch to remove the check. It also means 
the use of admin/js/jquery-ui-1.8.6.min.js is limited to the tinymce popup 
window.

3. On the wordpress page it says that the minimum required version for the 
plugin is 3.2. In the code it is 3.1. I think there should be consistency 
between the requirements. I would advocate for setting a requirement of 3.2 
since that implies that you will need php5.2, mysql 5 and not least ie6 is no 
more supported. That should make it possible to simplify the code.

Original issue reported on code.google.com by kristian...@gmail.com on 22 Jan 2012 at 9:06

Attachments:

GoogleCodeExporter commented 8 years ago
Apparently  I make typos when I try to correct them. Here is a more correct 
version of the nggallery patch

Original comment by kristian...@gmail.com on 23 Jan 2012 at 6:24

Attachments:

GoogleCodeExporter commented 8 years ago
Indeed I need to clean up a bit and remove pre 3.2 codes, thanks to point this 
out.

Removed as well jquery-ui-1.8.6.min.js in tinymce popup, should be here better 
apply in the future the WP script loader instead to direct point the script 
filenames

Done in r1066 + r1067

Original comment by alex.cologne on 5 Feb 2012 at 5:30