search

samtools / bcftools

This is the official development repository for BCFtools. See installation instructions and other documentation here http://samtools.github.io/bcftools/howtos/install.html
http://samtools.github.io/bcftools/
Other
649 stars 240 forks source link

address multiple typos #2059

Closed emollier closed 8 months ago

emollier commented 8 months ago

In the lot there are a number of instances of "allows to" which in its correct form should be "allows one to", but also a couple of other things caught by lintian, Debian's static package linter.

jmarshall commented 8 months ago

There are better ways to rephrase these involving omitting ‘allows’ or using ‘allows/enables setting’ and similar rather than ‘allows to set’.

emollier commented 8 months ago

Hi John, I admit this is heavy and see whether I can improve the wording.

emollier commented 8 months ago

I tried to vary a bit the style, hopefully the meaning hasn't suffered in the process. I separated what I could to ease further commit references if need be.

jmarshall commented 8 months ago

It's not my role to review this formally. My comment was intended as a signal more for the maintainers than for the PR author.

emollier commented 8 months ago

Acknowledged, anyways, it is there in case there is interest.

Have a nice day, :) Étienne.

emollier commented 8 months ago

Hi Rob,

Thank you for having taken the time to lookup these changes. I went through your suggestions and found they greatly improved the wording in every case.

Happy new year! :) Étienne.

pd3 commented 8 months ago

@emollier @daviesrob, thank you for polishing the language, much appreciated.