samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

Deprecate SQTagUtil #1214

Closed magicDGS closed 5 years ago

magicDGS commented 5 years ago

Description

Closes https://github.com/samtools/htsjdk/issues/949

Checklist

codecov-io commented 5 years ago

Codecov Report

Merging #1214 into master will increase coverage by 0.006%. The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #1214       +/-   ##
===============================================
+ Coverage     68.702%   68.708%   +0.006%     
  Complexity      8061      8061               
===============================================
  Files            542       542               
  Lines          32711     32711               
  Branches        5533      5533               
===============================================
+ Hits           22473     22475        +2     
+ Misses          8038      8036        -2     
  Partials        2200      2200
Impacted Files Coverage Δ Complexity Δ
src/main/java/htsjdk/samtools/SQTagUtil.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...va/htsjdk/samtools/sra/SRAIndexedSequenceFile.java 62.162% <0%> (-2.703%) 6% <0%> (-1%)
...sjdk/samtools/util/Md5CalculatingOutputStream.java 74.359% <0%> (+7.692%) 8% <0%> (+1%) :arrow_up:
lbergelson commented 5 years ago

I'm going to merge this as is because I want it to go in at the same time as the other samtag deprecations.

magicDGS commented 5 years ago

Sorry for not answering - I had too much problems last months and I could not focus on this. Thanks for merging!