Codecov Report

Merging #1246 into master will increase coverage by 0.004%. The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #1246       +/-   ##
===============================================
+ Coverage     69.407%   69.412%   +0.004%     
  Complexity      8157      8157               
===============================================
  Files            548       548               
  Lines          32691     32689        -2     
  Branches        5521      5521               
===============================================
  Hits           22690     22690               
+ Misses          7783      7781        -2     
  Partials        2218      2218

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/htsjdk/samtools/SamStreams.java	`72.308% <ø> (ø)`	`19 <0> (ø)`	:arrow_down:
src/main/java/htsjdk/samtools/util/IOUtil.java	`57.143% <ø> (ø)`	`115 <0> (ø)`	:arrow_down:
...in/java/htsjdk/variant/vcf/VCFIteratorBuilder.java	`94.286% <100%> (-0.309%)`	`9 <0> (ø)`
...ain/java/htsjdk/variant/utils/VCFHeaderReader.java	`100% <100%> (ø)`	`6 <0> (ø)`	:arrow_down:
...va/htsjdk/samtools/sra/SRAIndexedSequenceFile.java	`62.162% <0%> (-2.703%)`	`6% <0%> (-1%)`
...samtools/util/AsyncBlockCompressedInputStream.java	`76% <0%> (+4%)`	`13% <0%> (+1%)`	:arrow_up:

romanzenka commented 5 years ago

Looks like there is a tiiiny coverage drop thanks to an exception being thrown when stream does not have "markSupported". And apparently the MD5 hashing somehow shook out to work so that nobody ever hits MD5 hashes shorter than 32 so no need to pad them (?)... I can try helping with that if you want, but it looks very minor.

lbergelson commented 5 years ago

@romanzenka Thank you for the offer, I wouldn't worry about that, our coverage detection always fails do to minor changes. I need to fix it...

samtools / htsjdk

resolving some nitpicks from pr #1245 #1246

Codecov Report