samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

CRAM: correct CT and MF encoding datatypes from byte to int #1319

Closed jmthibault79 closed 5 years ago

jmthibault79 commented 5 years ago

Also add a test demonstrating that the old byte-based code did not cause problems because byte and int codecs are identical for the full range of the fields

Checklist

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@019465f). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff             @@
##             master     #1319   +/-   ##
==========================================
  Coverage          ?   67.635%           
  Complexity        ?      8230           
==========================================
  Files             ?       562           
  Lines             ?     33617           
  Branches          ?      5642           
==========================================
  Hits              ?     22737           
  Misses            ?      8706           
  Partials          ?      2174
Impacted Files Coverage Δ Complexity Δ
...amtools/cram/encoding/reader/CramRecordReader.java 85.256% <ø> (ø) 26 <0> (?)
...amtools/cram/encoding/writer/CramRecordWriter.java 89.231% <ø> (ø) 26 <0> (?)
...ava/htsjdk/samtools/cram/structure/DataSeries.java 100% <100%> (ø) 8 <0> (?)
...samtools/cram/structure/CramCompressionRecord.java 92.969% <100%> (ø) 113 <2> (?)