samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

*CRAMCRAIIndexerTest testMultiRefContainer tests a BAI index #1339

Closed cmnbroad closed 4 years ago

cmnbroad commented 5 years ago

The testMultiRefContainer method is confusing/misleading because its physically in the CRAMCRAIIndexerTest file, and is intended to test a CRAI index, but because it uses CRAMContainerStreamWriter to create the index, its actually creating and testing a default BAI index.

cmnbroad commented 5 years ago

Fixed in refactoring branch.

cmnbroad commented 4 years ago

Fixed via https://github.com/samtools/htsjdk/pull/1440.