samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

Addresses part of issue #18, Allele class refactoring. #1370

Open vruano opened 5 years ago

vruano commented 5 years ago

More concretely it refactor the Allele class:

Description

Please explain the changes you made here. Explain the motivation for making this change. What existing problem does the pull request solve?

Checklist

vruano commented 5 years ago

Allele.java diffs rather messy perhaps reviewers should consider to assess it on the changed version of the file and go back to the github diff just report what they don't like.

vruano commented 5 years ago

Current test pass but need to add new ones, please review in the meantime.

vruano commented 5 years ago

I'm adding test code and fixing issues in the code as I come across them, you can start reviewing the first commit only for stability.