samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

Suppress all exceptions during DeleteOnExitPathHook #1409

Closed lbergelson closed 5 years ago

lbergelson commented 5 years ago

Description

codecov-io commented 5 years ago

Codecov Report

Merging #1409 into master will increase coverage by 0.002%. The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #1409       +/-   ##
===============================================
+ Coverage     68.101%   68.102%   +0.002%     
  Complexity      8373      8373               
===============================================
  Files            573       573               
  Lines          33963     33965        +2     
  Branches        5668      5668               
===============================================
+ Hits           23129     23131        +2     
+ Misses          8645      8644        -1     
- Partials        2189      2190        +1
Impacted Files Coverage Δ Complexity Δ
...htsjdk/samtools/util/nio/DeleteOnExitPathHook.java 80.952% <100%> (-8.521%) 3 <1> (-1)
src/main/java/htsjdk/samtools/util/Log.java 54.321% <0%> (+2.469%) 21% <0%> (+1%) :arrow_up:
lbergelson commented 5 years ago

I don't know why it wouldn't. It's basically just writing to system.err so unless you're 100% out of memory it doesn't seem like it would be problematic. I googled for restrictions on shutdown hooks and the only thing that's definitely not allowed is registering a new shutdown hook. I'm definitely not an expert on it though, so I might be wrong...