search

samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

add method we killed accidentally #1433

Closed lbergelson closed 4 years ago

lbergelson commented 4 years ago

We accidentally deleted a method when adding path options, adding it and a missed Pathification.

lbergelson commented 4 years ago

@cmnbroad Can you take a quick look at this?

codecov-io commented 4 years ago

Codecov Report

Merging #1433 into master will decrease coverage by 0.004%. The diff coverage is 0%.

@@              Coverage Diff               @@
##             master     #1433       +/-   ##
==============================================
- Coverage     68.35%   68.346%   -0.004%     
  Complexity     8489      8489               
==============================================
  Files           583       583               
  Lines         34389     34391        +2     
  Branches       5729      5729               
==============================================
  Hits          23505     23505               
- Misses         8665      8667        +2     
  Partials       2219      2219
Impacted Files Coverage Δ Complexity Δ
...c/main/java/htsjdk/tribble/index/IndexFactory.java 74.269% <0%> (-0.879%) 33 <0> (ø)
lbergelson commented 4 years ago

No problem. This is why I run automated comparisons before doing a release...