search

samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

Reduce test output from BlockCompressedInputStreamTest test method args. #1441

Closed cmnbroad closed 4 years ago

cmnbroad commented 4 years ago

We're within about 20k of the 5MB log output limit on travis - with my cram branch we go way over. A lot of it is the expansion of test method arg values. This change suppresses about 500k of output by wrapping large list inputs in a Supplier.

codecov-io commented 4 years ago

Codecov Report

Merging #1441 into master will decrease coverage by 0.029%. The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #1441       +/-   ##
===============================================
- Coverage     68.441%   68.412%   -0.029%     
+ Complexity      8504      8499        -5     
===============================================
  Files            583       583               
  Lines          34412     34412               
  Branches        5729      5729               
===============================================
- Hits           23552     23542       -10     
- Misses          8642      8649        +7     
- Partials        2218      2221        +3
Impacted Files Coverage Δ Complexity Δ
...dk/samtools/seekablestream/SeekableHTTPStream.java 58.824% <0%> (-7.353%) 14% <0%> (-3%)
...htsjdk/samtools/seekablestream/SeekableStream.java 68.75% <0%> (-6.25%) 9% <0%> (-1%)
...amtools/seekablestream/SeekableBufferedStream.java 89.091% <0%> (-3.636%) 16% <0%> (-1%)
...in/java/htsjdk/samtools/SAMSequenceDictionary.java 73.239% <0%> (-2.113%) 45% <0%> (-1%)
...htsjdk/samtools/util/nio/DeleteOnExitPathHook.java 90.476% <0%> (+9.524%) 4% <0%> (+1%) :arrow_up:
cmnbroad commented 4 years ago

Not sure if there is a better solution, but these changes reduce the log output by about 1MB.