Open lbergelson opened 4 years ago
@yfarjoun Do you know what the deal with the tests is? Didn't you have a minor fix for some self-recursive call?
@yfarjoun Oh man, this is MY PR... not yours. I was thinking this was the one that added new getters for attributes. Woops!
hehe. that vacation left you real fresh!
Merging #1508 into master will increase coverage by
0.007%
. The diff coverage is100.000%
.
@@ Coverage Diff @@
## master #1508 +/- ##
===============================================
+ Coverage 69.343% 69.350% +0.007%
- Complexity 8900 8902 +2
===============================================
Files 601 601
Lines 35503 35511 +8
Branches 5901 5901
===============================================
+ Hits 24619 24627 +8
Misses 8548 8548
Partials 2336 2336
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../htsjdk/variant/variantcontext/VariantContext.java | 78.125% <100.000%> (+0.121%) |
239.000 <2.000> (+2.000) |
|
src/main/java/htsjdk/variant/vcf/VCFConstants.java | 92.308% <100.000%> (+4.808%) |
1.000 <0.000> (ø) |
@BoscoSuent this was quick so I added it, it should fix your issue.