search

samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

Fix restoration of read base feature code. #1590

Closed cmnbroad closed 2 years ago

cmnbroad commented 2 years ago

Fixes https://github.com/samtools/htsjdk/issues/1379. This was originally marked as fixed in the 2020 refactoring branch, but @yash-puligundla ran into it while verifying compliance with hts-specs files for https://github.com/samtools/htsjdk/issues/1587.

cmnbroad commented 2 years ago

@yash-puligundla FYI, in case you have review comments or questions (for some reason I can't tag you as a reviewer). You might want to include these changes for any subsequent compliance tests your run.

yash-puligundla commented 2 years ago

Thank you, Chris. I will do that.

On Tue, Jan 4, 2022 at 8:58 AM Chris Norman @.***> wrote:

@yash-puligundla https://github.com/yash-puligundla FYI, in case you have review comments or questions (for some reason I can't tag you as a reviewer). You might want to include these changes for any subsequent compliance tests your run.

— Reply to this email directly, view it on GitHub https://github.com/samtools/htsjdk/pull/1590#issuecomment-1004833065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVHVIITEJPNM6GOKZ7ODK5DUUL4GZANCNFSM5LF6UQIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>