samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
283 stars 242 forks source link

Update to a version of snappy that natively supports apple silicon. #1594

Closed tfenne closed 2 years ago

tfenne commented 2 years ago

Description

Running HTSJDK-based apps on Apple Silicon currently fails if the snappy support is used. Upgrading to the latest version of snappy fixes this as it is aware of and bundles a dylib for Apple Silicon.

Things to think about before submitting:

codecov-commenter commented 2 years ago

Codecov Report

Merging #1594 (71d8a25) into master (b5af659) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff             @@
##              master     #1594   +/-   ##
===========================================
  Coverage     69.839%   69.839%           
  Complexity      9647      9647           
===========================================
  Files            702       702           
  Lines          37638     37638           
  Branches        6113      6113           
===========================================
  Hits           26286     26286           
  Misses          8903      8903           
  Partials        2449      2449           
lbergelson commented 2 years ago

@tfenne https://github.com/samtools/htsjdk/pull/1580/commits.

tfenne commented 2 years ago

Closing as a duplicate of #1580