search

samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
278 stars 244 forks source link

Refactoring VariantContextComparator #1629

Open lbergelson opened 1 year ago

lbergelson commented 1 year ago

@clintval I might have gone a bit overboard on refactoring. I really hate how normal comparators are written and like to rewrite them as the newer Comparator.comparing() chains so I did that.

It's great that you added tests, I ended up condensing them into a single test case with a dataprovider and a few additional use cases. I never would have bothered having any if you hadn't mad them in the first place though!

lbergelson commented 1 year ago

@cmnbroad Could you take a look at this, it ended up being more new code than I meant it to be so it probably needs a second pair of eyes.

lbergelson commented 1 year ago

blocked because of https://github.com/samtools/htsjdk/issues/1637