samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
278 stars 244 forks source link

add SINGULAR platform to read group #1635

Closed omicsorama closed 1 year ago

omicsorama commented 1 year ago

Description

This change is to allow Singular Genomics platform id in read groups. This update adds support for new sequencing vendor platform

Things to think about before submitting:

lbergelson commented 1 year ago

@omicsorama Hello. I see you also have a specs change proposed to add this value. I'm happy to add this update this but I'm going to wait for a bit in case there's any feedback on that pr.

Are you a representative of Singular? Are they producing data with this value at the moment?

omicsorama commented 1 year ago

@lbergelson Yes i made the parallel PR to keep docs and tool in step. Makes sense to wait a bit for feedback. Thanks.

Yes I am on the Bioinformatics team at Singular and we are holding off on producing data with this value until our customers can use a published htsjdk version that supports it

Happy to address any other questions!

lbergelson commented 1 year ago

@omicsorama Thanks for the info. It seems like it should be uncontroversial then if the name is coming straight from the source.

lbergelson commented 1 year ago

This seems to have been merged in specs so I'm going to merge it. Thank you @omicsorama