samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.
http://samtools.github.io/htsjdk/
278 stars 244 forks source link

Removing scala test infrastructure #1640

Closed lbergelson closed 1 year ago

lbergelson commented 1 year ago

This leaves in place the now defunct scala tests:

These will need to be back ported to java. This allows us to move to a new version of gradle and eventually to new jvm versions in a much simplified way. It also looks like it may speed up the tests.

cmnbroad commented 1 year ago

@lbergelson Were we previously exporting all of our dependencies, and if so, are we going to break clients now by having a narrower surface area ?

lbergelson commented 1 year ago

@cmnbroad I'm hoping we don't.... I don't believe we export any of the newly implementationed ones in our public API but I don't know how to check that automatically. It might cause issues for people who are depending on ours for their own cod without realizing it, but that should be an easy fix for them. If know how to check the API in a sane way that would be very useful, it's definitely something a tool could exist for.

cmnbroad commented 1 year ago

@yash-puligundla This PR might fix the "no test events" issues you were previously seeing (I seem to remember thinking that scala-test was implicated for that). You might rebase on this once it goes in.