Updating tests in SAMRecordUnitTest to remove ambiguity

samtools / htsjdk

A Java API for high-throughput sequencing data (HTS) formats.

http://samtools.github.io/htsjdk/

283 stars 243 forks source link

Updating tests in SAMRecordUnitTest to remove ambiguity #1696

Closed lbergelson closed 9 months ago

lbergelson commented 9 months ago

Tests were failing on Debian systems due to ambiguity between boxed and unboxed number comparisons in SAMRecordUnitTest See https://github.com/samtools/htsjdk/issues/1695
Fix the ambiguity by explicitly converting values to the primitive types before comparing
Fixes #1695

lbergelson commented 9 months ago

@pgrt I've applied your patch. I'm not sure why it's necessary on your system and not on mine, but if it helps I'm happy to include it. Thanks for submitting!

pgrt commented 9 months ago

Hi,

Thanks for taking it into account! In Debian we are getting ready for having openjdk-21 as the default jdk, perhaps the discussed error was triggered by the fact I built with this recent jdk.

Have a great week,

Pierre