Drop duplicate FORMAT tags and fix an error with dropping large tags

samtools / htslib

C library for high-throughput sequencing data formats

Other

803 stars 446 forks source link

Drop duplicate FORMAT tags and fix an error with dropping large tags #1752

Closed pd3 closed 6 months ago

pd3 commented 7 months ago

The removal of large tags introduced by https://github.com/samtools/htslib/commit/b49eea478114759efe19e718c38e7deb00614b21 and https://github.com/samtools/htslib/commit/9db565de3d89235f625de07363f1cd726c43f8f2 could not work correctly, the memmove pointers were wrong!

Resolves https://github.com/samtools/htslib/issues/1733

This is a fix of the botched pull request https://github.com/samtools/htslib/pull/1736

pd3 commented 6 months ago

This is now fixed and tested extensively, should be ready to go.

jkbonfield commented 6 months ago

I'll try rebasing and pushing back. Some of these build errors are due to you basing this on an old htslib, which used htscodecs 1.4 instead of the current release (1.6).