search

samtools / htslib

C library for high-throughput sequencing data formats
Other
783 stars 447 forks source link

assert(0) is bad practice #1791

Closed mp15 closed 1 week ago

mp15 commented 1 week ago

if you compile with NDEBUG asserts go away https://github.com/samtools/htslib/blob/5f205334cd04bcdac74b1b6d46f88d57a05eaf1c/synced_bcf_reader.c#L545 suggest replacing with abort();

pd3 commented 1 week ago

It should be fixed, thank you.