samubarb / Sagrada

0 stars 0 forks source link

Jenkins compilation issues #1

Closed valerio-castelli closed 6 years ago

valerio-castelli commented 6 years ago

Good afternoon, as of today (May 23rd), your code is not compiling correctly on Jenkins due to your usage of the com.sun.xml.internal.ws.policy.privateutil package, which is not supported by Jenkins. Please fix the issue my removing this dependency and moving to a non-internal library (that must be included in your pom.xml).

ingconti commented 6 years ago

other issue: now You have:

Tests run: 16, Failures: 3, Errors: 0, Skipped: 0

[ERROR] There are test failures.

valerio-castelli commented 6 years ago

Now working fine, closing.

valerio-castelli commented 6 years ago

One of your tests is making the compilation fail:

Running it.polimi.ingsw.controllerTest.NetworkSettingsTest Il file ./JSONconf/ServerSettings.json non esiste. Controlla la correttezza del percorso o del nome.

Results :

Failed tests: it.polimi.ingsw.controllerTest.AdapterPlayerTest#testprintPlayer ArrayIndexOutOfBoundsException

Until yesterday it was working fine. Please fix it ASAP.

samubarb commented 6 years ago

should be all fixed now. Thanks

valerio-castelli commented 6 years ago

It compiles, but you have test failures:

Failed tests: it.polimi.ingsw.controllerTest.AdapterPatternTest#testprintPattern ArrayIndexOutOfBoundsException it.polimi.ingsw.controllerTest.AdapterPatternTest#testprintPatterns ArrayIndexOutOfBoundsException it.polimi.ingsw.viewTest.VPlayerTest#testprintPlayersTest ArrayIndexOutOfBoundsException

samubarb commented 6 years ago

fixed also the others

valerio-castelli commented 6 years ago

Please remember to actually push your commits, we're still seeing the old one!

valerio-castelli commented 6 years ago

It's ok now.