search

samubarb / Sagrada

0 stars 0 forks source link

Sagrada/src/main/java/it/polimi/ingsw/view/VGame.java Add is not robust. #2

Closed ingconti closed 6 years ago

ingconti commented 6 years ago

in "Sagrada/src/main/java/it/polimi/ingsw/view/VGame.java"

a) you add without testing if no more space. b) I cannot see remove.

samubarb commented 6 years ago

the class is actually a placeholder, it's not implemented nor used yet

ingconti commented 6 years ago

pls DO NOT close issues by yourself, instructors will do upon verifications.

valerio-castelli commented 6 years ago

This seems to be fixed; however, I noticed in the same class you perform this test: if (this.players.size() >= 5) The maximum number of players, as any other constant value, should be parametrized with a static final attribute. Please refactor your code to fix all instances of this issue.

ingconti commented 6 years ago

we spent a lab session (or 2)... about this point. :)

samubarb commented 6 years ago

it's now fixed, thanks for reporting it