search

samuel-pratt / bc-ferries-api

🛳 The only public API for retrieving current data on BC Ferries sailings.
https://bcferriesapi.ca
MIT License
32 stars 10 forks source link

Code doesn’t have reference to Bowen Island Ferries, despite readme saying it should work. #24

Closed cnrlw closed 2 years ago

cnrlw commented 2 years ago

I can’t seem to find reference to Bowen Island (Snug Cove) in the code, and I can’t get the API to return any results for Bowen, but the README says it is built to reference Bowen island as a departure and destination.

samuel-pratt commented 2 years ago

That's leftover from before I ported this over to go. I'll do a cleanup this weekend and remove any unused ports.

samuel-pratt commented 2 years ago

I've removed the reference to Bowen Island for now. I'm planning on adding the smaller ports back sometime in the future.

cnrlw commented 2 years ago

Ah, ok. Thanks for the update.

I live on Bowen and have made a simple iOS shortcut that retrieves the ferry schedule for me (geofenced by whatever side I am on). I'm scraping their website to do so, but the markup is a bit unreliable / annoying to work with so I was thinking of using your API instead. FWIW.

Thanks for building and sharing your work!

On Sun, Dec 12, 2021 at 5:14 PM Sam Pratt @.***> wrote:

I've removed the reference to Bowen Island for now. I'm planning on adding the smaller ports back sometime in the future.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samuel-pratt/bc-ferries-api/issues/24#issuecomment-992022481, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAODASYYA5DKLPGIBKOZS3UQVCGJANCNFSM5JNWB5IA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

samuel-pratt commented 2 years ago

My main concern was if the core schedule object would get too crowded, but maybe it could work to add another one. So you request the base url, it returns an object with schedule, scraped at, and another entry for the routes that don't report capacities.

Instead of each route containing an array of objects like the schedule, it could just be an array of strings for each route. Would that work for your use case?

cnrlw commented 2 years ago

Yeah I think that would work for what I need.

samuel-pratt commented 2 years ago

Perfect, I'll aim to implement that this week.

cnrlw commented 2 years ago

Amazing!

samuel-pratt commented 2 years ago

Small update on this, there are so many more small terminals than i thought. I'm working through them but I might be updating it just with a few to start.

cnrlw commented 2 years ago

Thanks for the update.

On Sun, Dec 19, 2021 at 10:27 PM Sam Pratt @.***> wrote:

Small update on this, there are so many more small terminals than i thought. I'm working through them but I might be updating it just with a few to start.

— Reply to this email directly, view it on GitHub https://github.com/samuel-pratt/bc-ferries-api/issues/24#issuecomment-997634581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAODAQR4GRXIQAWHAJAEF3UR3EG5ANCNFSM5JNWB5IA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

samuel-pratt commented 2 years ago

Sorry for the late update on this, I made a few attempts to add all the smaller terminals to this api but there are just so many. I think I'm going to keep this api to routes that report capacity, and look at creating a separate one in the future that focuses only on schedules. The scrape each minute method doesn't make sense with mostly static data.

davidascher commented 2 years ago

Fyi I made islandtimes.ca just for fun and with no sophistication.

samuel-pratt commented 2 years ago

Fyi I made islandtimes.ca just for fun and with no sophistication.

Just trying to give a heads up to anyone using this api, I have made a large update that will break current uses and route codes will need to be updated. You can check the readme for info on the new routes, and a sample response from the api.

davidascher commented 2 years ago

Noted. I don't use the API. Change at will from my PoV.

On Wed, Mar 23, 2022 at 11:13 AM Sam Pratt @.***> wrote:

Fyi I made islandtimes.ca just for fun and with no sophistication.

Just trying to give a heads up to anyone using this api, I have made a large update that will break current uses and route codes will need to be updated. You can check the readme for info on the new routes, and a sample response from the api.

— Reply to this email directly, view it on GitHub https://github.com/samuel-pratt/bc-ferries-api/issues/24#issuecomment-1076662839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMQTS7V2UTQY4QHI7KT7LVBNNLVANCNFSM5JNWB5IA . You are receiving this because you commented.Message ID: @.***>