search

samuel-pratt / bc-ferries-api

🛳 The only public API for retrieving current data on BC Ferries sailings.
https://bcferriesapi.ca
MIT License
34 stars 11 forks source link

BC Ferry Times Data Bug #29

Closed pbadams closed 2 years ago

pbadams commented 2 years ago

Hi @samuel-pratt, leaving a bug report for BC Ferry app here as I couldn't find an option to send feedback in the app.

There might be a bug in the data API when querying a route before the first sailing of the day. The app is reporting "No more departures today" when I try to lookup HSB to LNG at 07:28 (before first scheduled sailing from HSB to LNG at 07:30) This also gives an error when trying reverse route from LNG to HSB before the first sailing from HSB.

After first sailing, the view is properly populated.

Before First Sailing image

After First Sailing image

Cheers, Paul A. (Sunshine Coast, BC)

samuel-pratt commented 2 years ago

Thanks for opening an issue, I really should just add a feedback / bug report spot in the app.

I'm not sure what this could be but I'll see if I can reproduce it tomorrow morning before the first sailing.

samuel-pratt commented 2 years ago

I've checked this a few mornings and haven't been able to reproduce the issue. I'll keep an eye out for it and will be adding integration testing soon to check for issues like this as they pop up. My hope is that the BC Ferries website hadn't updated for that morning yet.

I'll check for this again, but I'm not sure if there's a fix I can do at this right now.

Thanks for downloading Ferry Times and reporting the issue, I really appreciate it!